Skip to content

Commit

Permalink
MDL-84526 theme_boost: Fix forum table after BS5 upgrade
Browse files Browse the repository at this point in the history
Bootstrap 5 upgrade in MDL-75669 generated a regression in Forum table
where form switches in "Subscribe" column were not correcly displayed.
This commit fixes that UI problem.
Because the fix is affecting "toggle all" checkboxes, an small fix was
also needed there.
  • Loading branch information
roland04 committed Feb 12, 2025
1 parent 69bcc25 commit 7afb004
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion mod/forum/templates/discussion_list.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@
{{#forum.capabilities.subscribe}}
<td class="text-center align-middle fit-content px-2">
{{#discussion}}
<div class="d-inline form-check form-switch mb-1">
<div class="form-check form-switch mb-1">
<input
type="checkbox"
class="form-check-input"
Expand Down
3 changes: 0 additions & 3 deletions theme/boost/scss/moodle/tables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
padding: $table-cell-padding;
vertical-align: top;
border-top: $table-border-width solid $table-border-color;
.form-check {
padding: 0;
}
}

thead th,
Expand Down
4 changes: 0 additions & 4 deletions theme/boost/style/moodle.css
Original file line number Diff line number Diff line change
Expand Up @@ -37298,10 +37298,6 @@ img.userpicture {
vertical-align: top;
border-top: var(--bs-border-width) solid var(--bs-border-color);
}
.generaltable th .form-check,
.generaltable td .form-check {
padding: 0;
}
.generaltable thead th,
.generaltable thead td {
vertical-align: bottom;
Expand Down
4 changes: 0 additions & 4 deletions theme/classic/style/moodle.css
Original file line number Diff line number Diff line change
Expand Up @@ -37304,10 +37304,6 @@ img.userpicture {
vertical-align: top;
border-top: var(--bs-border-width) solid var(--bs-border-color);
}
.generaltable th .form-check,
.generaltable td .form-check {
padding: 0;
}
.generaltable thead th,
.generaltable thead td {
vertical-align: bottom;
Expand Down

0 comments on commit 7afb004

Please sign in to comment.