From 7afb00464d607cd723685adb6552faa003ba6de4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mikel=20Mart=C3=ADn?= <mikel@moodle.com>
Date: Wed, 12 Feb 2025 16:05:37 +0100
Subject: [PATCH] MDL-84526 theme_boost: Fix forum table after BS5 upgrade

Bootstrap 5 upgrade in MDL-75669 generated a regression in Forum table
where form switches in "Subscribe" column were not correcly displayed.
This commit fixes that UI problem.
Because the fix is affecting "toggle all" checkboxes, an small fix was
also needed there.
---
 mod/forum/templates/discussion_list.mustache | 2 +-
 theme/boost/scss/moodle/tables.scss          | 3 ---
 theme/boost/style/moodle.css                 | 4 ----
 theme/classic/style/moodle.css               | 4 ----
 4 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/mod/forum/templates/discussion_list.mustache b/mod/forum/templates/discussion_list.mustache
index a7c74774aa7b8..3097bfa05e701 100644
--- a/mod/forum/templates/discussion_list.mustache
+++ b/mod/forum/templates/discussion_list.mustache
@@ -316,7 +316,7 @@
                                 {{#forum.capabilities.subscribe}}
                                     <td class="text-center align-middle fit-content px-2">
                                         {{#discussion}}
-                                            <div class="d-inline form-check form-switch mb-1">
+                                            <div class="form-check form-switch mb-1">
                                                 <input
                                                     type="checkbox"
                                                     class="form-check-input"
diff --git a/theme/boost/scss/moodle/tables.scss b/theme/boost/scss/moodle/tables.scss
index 64aec292b973a..770d35c4029f0 100644
--- a/theme/boost/scss/moodle/tables.scss
+++ b/theme/boost/scss/moodle/tables.scss
@@ -12,9 +12,6 @@
         padding: $table-cell-padding;
         vertical-align: top;
         border-top: $table-border-width solid $table-border-color;
-        .form-check {
-            padding: 0;
-        }
     }
 
     thead th,
diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css
index feb0b6c05daf5..1979e59f6922c 100644
--- a/theme/boost/style/moodle.css
+++ b/theme/boost/style/moodle.css
@@ -37298,10 +37298,6 @@ img.userpicture {
   vertical-align: top;
   border-top: var(--bs-border-width) solid var(--bs-border-color);
 }
-.generaltable th .form-check,
-.generaltable td .form-check {
-  padding: 0;
-}
 .generaltable thead th,
 .generaltable thead td {
   vertical-align: bottom;
diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css
index e26b6090fd633..8600bd308a33f 100644
--- a/theme/classic/style/moodle.css
+++ b/theme/classic/style/moodle.css
@@ -37304,10 +37304,6 @@ img.userpicture {
   vertical-align: top;
   border-top: var(--bs-border-width) solid var(--bs-border-color);
 }
-.generaltable th .form-check,
-.generaltable td .form-check {
-  padding: 0;
-}
 .generaltable thead th,
 .generaltable thead td {
   vertical-align: bottom;