MDL-84526 theme_boost: Fix forum table after BS5 upgrade

Bootstrap 5 upgrade in MDL-75669 generated a regression in Forum table where form switches in "Subscribe" column were not correcly displayed. This commit fixes that UI problem. Because the fix is affecting "toggle all" checkboxes, an small fix was also needed there.
roland04 · Feb 21, 2025 · ace2086 · ace2086
1 parent 7a318d5
commit ace2086
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 22 deletions.
diff --git a/lib/templates/checkbox-toggleall-master.mustache b/lib/templates/checkbox-toggleall-master.mustache
@@ -37,7 +37,7 @@
         "labelclasses": "badge bg-info text-white"
     }
 }}
-<div class="form-check">
+<div class="form-check p-0">
     <input id="{{id}}" name="{{name}}" type="checkbox" class="{{classes}}" value="{{value}}"
            aria-labelledby="{{id}}-label"
            data-action="toggle"

diff --git a/mod/forum/templates/discussion_list.mustache b/mod/forum/templates/discussion_list.mustache
@@ -316,7 +316,7 @@
                                 {{#forum.capabilities.subscribe}}
                                     <td class="text-center align-middle fit-content px-2">
                                         {{#discussion}}
-                                            <div class="d-inline form-check form-switch mb-1">
+                                            <div class="form-check form-switch mb-1">
                                                 <input
                                                     type="checkbox"
                                                     class="form-check-input"

diff --git a/theme/boost/scss/moodle/grade.scss b/theme/boost/scss/moodle/grade.scss
@@ -491,9 +491,6 @@
                                     min-height: 30px;
                                     align-items: center;
 
-                                    .form-check {
-                                        padding: 0;
-                                    }
 
                                     a {
                                         &.toggle-category {

diff --git a/theme/boost/scss/moodle/tables.scss b/theme/boost/scss/moodle/tables.scss
@@ -12,9 +12,6 @@
         padding: $table-cell-padding;
         vertical-align: top;
         border-top: $table-border-width solid $table-border-color;
-        .form-check {
-            padding: 0;
-        }
     }
 
     thead th,

diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css
@@ -37298,10 +37298,6 @@ img.userpicture {
   vertical-align: top;
   border-top: var(--bs-border-width) solid var(--bs-border-color);
 }
-.generaltable th .form-check,
-.generaltable td .form-check {
-  padding: 0;
-}
 .generaltable thead th,
 .generaltable thead td {
   vertical-align: bottom;
@@ -37897,9 +37893,6 @@ p.arrow_button {
   min-height: 30px;
   align-items: center;
 }
-.path-grade-edit-tree .gradetree-wrapper .setup-grades.generaltable tr.category td.column-name div .form-check {
-  padding: 0;
-}
 .path-grade-edit-tree .gradetree-wrapper .setup-grades.generaltable tr.category td.column-name div a.toggle-category {
   height: 24px;
   width: 24px;

diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css
@@ -37304,10 +37304,6 @@ img.userpicture {
   vertical-align: top;
   border-top: var(--bs-border-width) solid var(--bs-border-color);
 }
-.generaltable th .form-check,
-.generaltable td .form-check {
-  padding: 0;
-}
 .generaltable thead th,
 .generaltable thead td {
   vertical-align: bottom;
@@ -37903,9 +37899,6 @@ p.arrow_button {
   min-height: 30px;
   align-items: center;
 }
-.path-grade-edit-tree .gradetree-wrapper .setup-grades.generaltable tr.category td.column-name div .form-check {
-  padding: 0;
-}
 .path-grade-edit-tree .gradetree-wrapper .setup-grades.generaltable tr.category td.column-name div a.toggle-category {
   height: 24px;
   width: 24px;