Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition on checkIgnore option is misleading #1150

Open
mathewbyrne opened this issue Feb 6, 2025 · 1 comment
Open

Type definition on checkIgnore option is misleading #1150

mathewbyrne opened this issue Feb 6, 2025 · 1 comment

Comments

@mathewbyrne
Copy link

The type definition for the checkIgnore configuration option is misleading as it tells developers that args is an array of LogArgument. We've found that actually what you're getting is a Javascript arguments object.

This means that although you can index into it, many array functions are not actually available to you on this object. The annotation should probably be updated to be iArguments.

This caused an issue for us where we were attempting to filter out specific errors by looping over args looking for ignored instances. Correct typing probably would have indicated earlier that this was not going to work.

Copy link

linear bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant