-
Notifications
You must be signed in to change notification settings - Fork 7
Update documentation regarding preserve_metadata
#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think with recent changes in terra it may be worth considering changing the Essentially the name and documentation should capture the idea of using a ZIP archive to retain all files whenever the target "write" method may create multiple files. This would include auxiliary metadata files, but is not technically be limited to just metadata. Something like:
Some drivers, e.g. ESRI Shapefile, ESRI File Geodatabase, Zarr always produce multi-file or directory output. Additional files in the latter cases are not specifically limited to "metadata" (could be attributes, SRS, etc) and also would apply to vector data sources, not just raster. Relatively recent terra changes to GeoTIFF and COG behavior mean that metadata are always stored internally for those file formats, so testing of the "preserve_metadata" functionality also should probably use a driver that requires use of multiple files, and test other user-set metadata storage from Tests I added in #123 for the |
Do you have a proposal for the new argument name? |
Perhaps something like I don't really have a better suggestion, and I think |
Maybe just |
Discussed initially in #141
Ever since rspatial/terra#1714, metadata is no longer stored in an aux.json file for many GDAL drivers. Let's double-check the documentation for the
preserve_metadata
argument and make sure it reflects this change appropriately. (may not need any change, this is just a reminder to take a look at it)The text was updated successfully, but these errors were encountered: