Do not allow lines of identify output containing whitespace only to crash the whole show #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crash the whole show. Make sure there is a : present. Example of
output that crashes when identify outputs lines containing whitespace only:
(I have added | marks to show where the whitespace ends. The | marks are
not in the actual output of identify.)
rdf:Alt: |
|
|
signature: a42e682fbf3b7a4aa29577935f6deed66e7a3e688a3edb8e3a0ccc7aad21d
My patch is to ignore lines with no : at all in them. Otherwise all
properties encountered before this point, including the format property,
are lost.
|
I have verified that the JPEG I attached came through faithfully, including the offending RDF property, so you can test with it if desired. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow lines of identify output containing whitespace only to crash the whole show. Make sure there is a : present. Example of output that crashes when identify outputs lines containing whitespace only:
(I have added | marks to show where the whitespace ends. The | marks are
not in the actual output of identify.)
My patch is to ignore lines with no : at all in them. Otherwise all properties encountered before this point, including the format property, are lost, and code in the imagemagick module that assumes there is a format property crashes.
I have attached the JPEG image that caused this result although I don't know whether github will regenerate it and lose the RDF property. I've seen this crash before, and now I know it relates to parseIdentify becoming confused, so if I spot other examples I'll track those down and patch them as well.