remove no longer used method. remove todo. tidy test code.

Author: rs-fraser

src/main/java/com/researchspace/service/impl/RecordManagerImpl.java

@@ -1088,7 +1088,7 @@ public List<BaseRecord> getFilteredRecordsList(WorkspaceFilters filters, User us
 
     if (filters.isMediaFilesFilter()) {
       Set<BaseRecord> mediaFiles = recordDao.getViewableMediaFiles(List.of(user));
-      addOrRetain(hits, init, mediaFiles);
+      init = addOrRetain(hits, init, mediaFiles);
 
       String mediaType = filters.getMediaFilesType();
       if (mediaType != null) {
@@ -1187,8 +1187,7 @@ private List<BaseRecord> getViewableRecordsByRole(User subject, boolean onlyTemp
       Set<BaseRecord> subjectsViewableRecords =
           new HashSet<>(getRecordsSharedWithUser(subject, onlyTemplates, subject));
 
-      // records created by each of the subjects viewable users TODO: can this be simplified with
-      // the permissions check?
+      // records created by each of the subjects viewable users
       for (User viewableUser : viewableUsers) {
         subjectsViewableRecords.addAll(
             getViewableRecordsByUsers(List.of(viewableUser), onlyTemplates));

src/main/java/com/researchspace/service/impl/SearchManagerImpl.java

@@ -167,10 +167,6 @@ private List<String> getUserFilterForInventory(User subject) {
     return invPermissionUtils.getUsernameOfUserAndAllMembersOfTheirGroups(subject);
   }
 
-  private List<BaseRecord> getFilteredRecords(WorkspaceFilters filters, User user) {
-    return recordManager.getFilteredRecordsList(filters, user);
-  }
-
   @Override
   public ISearchResults<BaseRecord> searchUserRecordsWithSimpleQuery(
       User user, String searchQuery, Integer maxResults) throws IOException {