Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot open xlsx in Excel in document, but can open the same xlsx in Excel from the Gallery #117

Closed
burgerga opened this issue Sep 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@burgerga
Copy link

burgerga commented Sep 19, 2024

Describe the bug
Probably minor UX bug, but I cannot open the document in Excel from https://leiden-test.researchspace.com/globalId/SD49173, but when I go to the gallery (https://leiden-test.researchspace.com/globalId/GL49175) I can open it in Excel.

To Reproduce
Not sure, weirdly, if I create a new file, and then insert the same file from the Gallery I do get the "Edit in Excel" button...

Expected behavior
File to have an "Open in Excel" button also in the document view

Screenshots
View from document:
image
Same file in gallery:
image

Additional context
Leiden RSpace test instance on version v1.101.2 (seems the same as production though)

@burgerga burgerga added the bug Something isn't working label Sep 19, 2024
Copy link
Contributor

Welcome to the RSpace open-source project! We're excited to have you here! To get started and learn more about the project, our code of conduct and contributor guidelines, please visit https://github.com/rspace-os/rspace-web/wiki

@burgerga
Copy link
Author

(reported the bot)

@rspace-os rspace-os deleted a comment Sep 19, 2024
@mKowalski256
Copy link
Contributor

mKowalski256 commented Sep 19, 2024

Thank you, reported the bot too, and also deleted the comment!

As for the ticket itself, is that maybe the case that the document that doesn't show the 'Open in Excel' link was restored from revision history? If that's the case we're aware of that bug, otherwise we'll investigate further.

@burgerga
Copy link
Author

Hmm, that could be the case, because I was looking at how revisions would work for the Excel integration, but to be honest I don't remember...

@tilorspace tilorspace moved this from Todo to In Progress in 👷 RSpace development Jan 3, 2025
@mKowalski256 mKowalski256 added this to the RSpace 2.7.0 milestone Feb 3, 2025
@tilorspace tilorspace moved this from In Progress to Done in 👷 RSpace development Feb 11, 2025
@tilorspace tilorspace closed this as completed by moving to Done in 👷 RSpace development Feb 11, 2025
@tilorspace
Copy link
Contributor

Attachments in restored document versions are now displayed as locked from direct editing. Additional disclaimers explain how historical attachment version can be reused if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants