Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 46 sysadmin delete button #51

Merged

Conversation

rlamacraft
Copy link
Contributor

The delete user sysadmin menu item is now disabled if the deployment property is set, with an explanation as such.
image

Furthermore, I've fixed the error handling for the network request to ensure that any other reason for the deletion operation failing is made apparent.

@rlamacraft
Copy link
Contributor Author

@mKowalski256 Do you want to double check that this works as intended before I merge it in?

@mKowalski256
Copy link
Contributor

Yes, will take a look.

Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested on AWS build, looks good to me!

@rlamacraft rlamacraft merged commit 98558de into rspace-os:main Jul 16, 2024
@rlamacraft rlamacraft deleted the issue-46-sysadmin-delete-button branch July 16, 2024 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants