Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDEV-225 Show all users in mentions list #57

Conversation

rlamacraft
Copy link
Contributor

This change displays all users in a scrolling list when the user enter the "@" key in a rich text field in the ELN, as opposed to the current functionality which arbitrarily limits the list to 10 users.

@rs-nicof
Copy link
Contributor

✅ Tested successfully ✅ on AWS instance https://rsdev-225-ui-and-server-new-2.researchspace.com/

Screen.sharing.-.2024-07-11.3_16_16.PM.mp4

@rs-nicof
Copy link
Contributor

PR looks good to me ✅

Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just retested on a build taken from the same branch as PR (https://rsdev-225-all-users-in-mentions-list-3.researchspace.com/), and I do see a full list available for mentions now.

@rlamacraft rlamacraft merged commit 1125832 into rspace-os:main Jul 16, 2024
2 checks passed
@rlamacraft rlamacraft deleted the rsdev-225-all-users-in-mentions-list branch July 16, 2024 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants