-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDEV-280: Return the list of Subsamples when cannot delete a Sample #59
RSDEV-280: Return the list of Subsamples when cannot delete a Sample #59
Conversation
79a3ae9
to
033025b
Compare
033025b
to
68b5f1b
Compare
68b5f1b
to
2eac49e
Compare
✅ Build full java testds passed: https://jenkins.researchspace.com/job/rspace-web/job/RSDEV-280-backend/16/ |
…eleted and ApiSubSample.storedInContainer flags, rather than in separate array of ApiSample
I've looked through the code, and eventually decided to change the way how info about which subsamples are problematic is encoded into API response. @rs-nicof to avoid enlarging sample response object I've only kept @rlamacraft that needs adjusting frontend code to new logic, basically in |
Oh right yeah, each sample might contain a mixture of subsamples that can or cannot be deleted. Ok, made the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me & tests are passing, @rs-nicof feel free to merge when you're back on Monday.
This change include changes to how the error message when deleting samples is shown. In the screenshot below, a sample with two subsamples in containers and a lone subsample from a different sample have been deleted. The former has failed as the subsamples are in containers (with the main part of this change being that those subsamples are now detailed and linked to), and the latter has been deleted correctly hence the green alert.