Rsdev 240 pdf page numbers #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that contiguous page numbering across docs or notebooks is honoured
…ether the page numbering should restart for each doc in a multi-doc/notebook export. Calculate the page number correctly for multi-doc/notebook export to fix contiguous numbering. Change logging level for logging of document html data to avoid clogging logs.
…ort is set correctly based on the config option selected for page numbering.
|
The code looks good to me! |
mKowalski256
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Code change looks good to me, and works fine on test AWS build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the page numbering where the user has selected not to restart page numbering for each doc in a multi-doc or notebook export, by passing the existing length of the pdf doc into the pdf writer i.e for a new doc or when page numbering should restart each doc, the length is 0, otherwise it's the length of the existing doc.
Also rename the config property
pageNametorestartPageNumberingPerDocthroughout the front and back-end code, aspageNamewas very confusing.And finally reduced the logging level for printing the pdf html input to debug since that's probably not something we need to log every time we export pdf as it could be very long.