issue-73: reworking API key display logic and ways for sysadmin to access it #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sysadmin 'operating as'; guarding API endpoint for apiKey retrieval with new deployment property 'sysadmin.apikey.access' which must be explicitly changed to 'true'
…ofile' page; also it should be fine for sysadmin to regenerate/revoke the key, just not to see pre-existing one
|
test AWS build running at https://issue-73-api-key-6.researchspace.com |
rs-fraser
reviewed
Jul 31, 2024
rs-fraser
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #73.
This PR consists of multiple changes that should make retrieval of API key more secure and traceable.
The changes in behaviour:
/apiKeyInfo/allendpoint withinUserDetailsSysAdminApiis now only available when deployment propertysysadmin.apikey.accessis set totrue(it'sfalseby default)