-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDEV-446: Amend the way when we create new document into a folder #263
Conversation
6889326
to
bfdf952
Compare
✅ Successfully tested on https://rsdev-446-web-14.researchspace.com/ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I see this PR skips unperforming action when creating new document, which I'd expect will speed up API creation scenario. But we definitely want to use new model method for sharing action, which is a call to selectedTargetFolder.addChild()
inside RecordSharingManagerImpl.doSharing()
method.
Do we want to tackle this one too, within this PR? Then we could test performance impact on AWS autosharing build - where sharing is a main problem. I think the way PR is now will not have much impact for autosharing scenario.
Yes, I would say let's try to tackle also the other 2 scenarios that you pounted out. |
fb1d4a8
to
8d16794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me & works fine at test instance.
src/main/java/com/researchspace/service/impl/RecordManagerImpl.java
Outdated
Show resolved
Hide resolved
8d16794
to
23629b5
Compare
Waiting for the last Full Test to pass and then will merge |
We use the flag 'skipChildrenAdd' when we: - create a document - share a document - copy a document
23629b5
to
8e7d135
Compare
No description provided.