Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDEV-446: Amend the way when we create new document into a folder #263

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

rs-nicof
Copy link
Contributor

@rs-nicof rs-nicof commented Feb 7, 2025

No description provided.

@rs-nicof rs-nicof force-pushed the RSDEV-446-web branch 2 times, most recently from 6889326 to bfdf952 Compare February 10, 2025 11:25
@rs-nicof
Copy link
Contributor Author

✅ Successfully tested on https://rsdev-446-web-14.researchspace.com/

Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I see this PR skips unperforming action when creating new document, which I'd expect will speed up API creation scenario. But we definitely want to use new model method for sharing action, which is a call to selectedTargetFolder.addChild() inside RecordSharingManagerImpl.doSharing() method.

Do we want to tackle this one too, within this PR? Then we could test performance impact on AWS autosharing build - where sharing is a main problem. I think the way PR is now will not have much impact for autosharing scenario.

@rs-nicof
Copy link
Contributor Author

rs-nicof commented Feb 11, 2025

Looks good to me!

I see this PR skips unperforming action when creating new document, which I'd expect will speed up API creation scenario. But we definitely want to use new model method for sharing action, which is a call to selectedTargetFolder.addChild() inside RecordSharingManagerImpl.doSharing() method.

Do we want to tackle this one too, within this PR? Then we could test performance impact on AWS autosharing build - where sharing is a main problem. I think the way PR is now will not have much impact for autosharing scenario.

Yes, I would say let's try to tackle also the other 2 scenarios that you pounted out.
Plus the copy scenario in DocumentCopyManagerImpl.copy(...) that looks like feasible as well

@rs-nicof rs-nicof force-pushed the RSDEV-446-web branch 6 times, most recently from fb1d4a8 to 8d16794 Compare February 14, 2025 15:07
Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me & works fine at test instance.

@rs-nicof
Copy link
Contributor Author

Looks good to me & works fine at test instance.

Waiting for the last Full Test to pass and then will merge

We use the flag 'skipChildrenAdd' when we:
 - create a document
 - share a document
 - copy a document
@rs-nicof rs-nicof merged commit 42a667d into rspace-os:main Feb 14, 2025
2 checks passed
@rs-nicof rs-nicof deleted the RSDEV-446-web branch February 14, 2025 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants