RSDEV-533 Refactor PyRAT tinymce plugin to avoid need for iframe #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlamacraft
force-pushed
the
rsdev-533-pyrat-without-iframe
branch
from
bfcd63a to
e91e6e2
Compare
|
@mKowalski256 any thoughts? I feel like this simplifies things, especially with the ultimate goal of reactifying the document editor. It means that any new plugins going forward will be easier to migrate when the time comes. The content of each dialog could be implemented in a separate node module by external collaborators if they would prefer, with the plugin set up code trivial even if we had to do it every time. |
|
Visually, it makes the PyRAT dialog look like this |
rlamacraft
force-pushed
the
rsdev-533-pyrat-without-iframe
branch
3 times, most recently
from
329f04a to
e37db14
Compare
rlamacraft
force-pushed
the
rsdev-533-pyrat-without-iframe
branch
from
e37db14 to
a8dfa76
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems excessive to render a react component inside of an iframe inside of a tinymce dialog, when we could just render the react component. Rendering the dialog directly also gives us full control over the styling, allowing us to using the accented theme based on each organisation's branding.