Typescript experimentation #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlamacraft
force-pushed
the
typescript-experimentation
branch
4 times, most recently
from
7e2676e to
63f421e
Compare
rlamacraft
force-pushed
the
typescript-experimentation
branch
6 times, most recently
from
48503be to
5875271
Compare
rlamacraft
force-pushed
the
typescript-experimentation
branch
13 times, most recently
from
214d516 to
4b16fb6
Compare
There are some jest tests failing!
rlamacraft
force-pushed
the
typescript-experimentation
branch
from
4b16fb6 to
a99be63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks add adding TypeScript to the codebase, making it work alongside Flow, Jest, Eslint, and the various other tools that we use, with the ultimate aim being to move the codebase from Flow to TypeScript in small pieces when we can find the time.
This migration works because both webpack and jest can transpile the flow and typescript code into javascript and then have the former call the later where necessary. To make the type check continue to work, the boundary between the flow js code at the root of the module tree and typescript at the leaves is annotated with a flow library declaration file so that the calling flow code can get the right types.
Also includes a few files; test subjects that were necessary in identifying all of the changes necessary to all of the config files to get everything working: some simple components, a test file, and a cyclical dependency.