Organise code that operates on units and their utility functions. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlamacraft
force-pushed
the
organise-units
branch
from
0590daf to
a545ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything relating to units and measure how lives in
src/stores/definitions/Units.js, which means thatsrc/util/*.jsfiles do not have to depend on code outside ofsrc/util/. This fixes a violation of a dependency cruiser rule, and makes it easier to migrate the code to TypeScript in a piecemeal fashion as the modules aren't so tightly coupled together. This change also adds documentation and removes some unused code.