-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[39] Addresses suggestions re iRODS file system setup UX #40
Conversation
Please note that #44 wants to merge into branch rspace-os:irods which has also all other needed changes. If this is confusing, I can just make a different PR with all needed changes. |
That's cool @ll4strw Thanks for addressing the comments. |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This PR now has changes coming from #44, and should be good to review again. I'll start test AWS build so we can confirm it's all fine to merge. |
Re-tested #44 changes at https://rspace-os-irods-2.researchspace.com, they look good to me. iRODS file system configuration panel before: iRODS file system configuration panel after: The PR is just js code changes to handle different label, and java code changes ensuring port 1247 for iRODS if no port is defined. |
Also @ll4strw please can you follow request of a "CLA Assistant Lite bot" from a few comments up, and add a Pull Request comment confirming you accept our CLA? |
@mKowalski256 Thanks for pulling this PR in. I am running rspace's CLA through our copyright/patent office for approval first. |
No description provided.