Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[39] Addresses suggestions re iRODS file system setup UX #40

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Conversation

ll4strw
Copy link
Collaborator

@ll4strw ll4strw commented Jun 28, 2024

No description provided.

@mKowalski256 mKowalski256 requested review from mKowalski256 and removed request for mKowalski256 June 28, 2024 15:06
@ll4strw
Copy link
Collaborator Author

ll4strw commented Jul 2, 2024

Please note that #44 wants to merge into branch rspace-os:irods which has also all other needed changes. If this is confusing, I can just make a different PR with all needed changes.

@ll4strw
Copy link
Collaborator Author

ll4strw commented Jul 4, 2024

@rs-nicof commit 2023e55 implements the requested changes. Please note that I merged all the changes that I had regarding these enhancements into #44 to keep everything in one place. I hope this is not confusing.

@rs-nicof
Copy link
Contributor

rs-nicof commented Jul 4, 2024

@rs-nicof commit 2023e55 implements the requested changes. Please note that I merged all the changes that I had regarding these enhancements into #44 to keep everything in one place. I hope this is not confusing.

 That's cool @ll4strw Thanks for addressing the comments.
 I would say better to close this PR, so we don't get confused 👍

Copy link
Contributor

github-actions bot commented Aug 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Retrieve and use default labels from system.properties.

---------

Co-authored-by: Maciej Kowalski <mKowalski256@users.noreply.github.com>
@mKowalski256
Copy link
Contributor

This PR now has changes coming from #44, and should be good to review again. I'll start test AWS build so we can confirm it's all fine to merge.

@mKowalski256
Copy link
Contributor

Re-tested #44 changes at https://rspace-os-irods-2.researchspace.com, they look good to me.

iRODS file system configuration panel before:
image

iRODS file system configuration panel after:
image

The PR is just js code changes to handle different label, and java code changes ensuring port 1247 for iRODS if no port is defined.
Unless anyone has any comments, I'll merge this PR before next release.

@mKowalski256 mKowalski256 self-requested a review August 16, 2024 11:10
@mKowalski256
Copy link
Contributor

Also @ll4strw please can you follow request of a "CLA Assistant Lite bot" from a few comments up, and add a Pull Request comment confirming you accept our CLA?

@ll4strw
Copy link
Collaborator Author

ll4strw commented Aug 16, 2024

@mKowalski256 Thanks for pulling this PR in. I am running rspace's CLA through our copyright/patent office for approval first.

@mKowalski256
Copy link
Contributor

I've re-checked the PR after latest merges, works fine for me. I see that on System screen there is new radio toggle between Native/PAM password type, looks good to me:
image

I also confirmed that previously-created iRODS configs work fine after change, and that screens for configuring Samba/SFTP behave the same. All looks good, so I'll merge now.

@mKowalski256 mKowalski256 merged commit 05f9231 into main Feb 3, 2025
2 checks passed
@mKowalski256 mKowalski256 deleted the irods branch February 3, 2025 17:49
@mKowalski256 mKowalski256 restored the irods branch February 3, 2025 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
@mKowalski256 mKowalski256 deleted the irods branch February 3, 2025 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants