Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#39] Addresses suggestions re iRODS file system setup UX. #44

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

ll4strw
Copy link
Collaborator

@ll4strw ll4strw commented Jul 2, 2024

Retrieve and use default labels from system.properties.

Copy link
Contributor

@rs-nicof rs-nicof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you possibly rebase your PR? 🙏
it looks like there are commits that are not part of it so it is difficult to understand what to review

@ll4strw
Copy link
Collaborator Author

ll4strw commented Jul 5, 2024

@rs-nicof rebase done.

Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@mKowalski256
Copy link
Contributor

mKowalski256 commented Aug 15, 2024

Let me merge this PR so we have all suggested fixes inside rspace-os:irods branch, and then the discussion is in PR #40 that is about merging all into rspace-os:main branch.

@mKowalski256 mKowalski256 requested a review from rs-nicof August 15, 2024 15:03
@mKowalski256 mKowalski256 merged commit af0e853 into rspace-os:irods Aug 15, 2024
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants