RSDEV-282 By default, hide all but the most recent two notes on subsamples #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If subsamples have lots of notes then it could make the UI quite cumbersome, especially where the subsample notes are now shown on the sample page they are no longer at the very foot of the page as they are on the subsample page.
This change hides all but the two most recent notes by default, with the rest hidden behind a "Show more" button. The new note field is placed at the top of the list, where it appears before the most recent note and is readily available even when the list of notes is long.
This change also improves the aesthetics of the notes somewhat, utilising the theme colour of the subsamples to make it clear that the notes are associated with the physical quantity of the sample, and not the grouping that forms the whole sample.