Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDEV-301 Add link to PyRAT server at top of generated table #75

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

rlamacraft
Copy link
Contributor

This change adds a row to the top of the table that is inserted into the rich text fields of documents by the PyRAT integrations. This row includes a link back to the PyRAT server and the date of when the table was generated.

image

@rlamacraft rlamacraft requested a review from mKowalski256 July 31, 2024 10:14
Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New link looks good and works fine for me (on localhost).

I'm slightly confused that inserted pyrat table in view mode doesn't seem to have styling of the regular table (no cell/row border lines), but that's unrelated to the issue tackled in this PR.

@rlamacraft rlamacraft merged commit 1620dd1 into rspace-os:main Aug 1, 2024
2 checks passed
@rlamacraft rlamacraft deleted the rsdev-301-pyrat-link branch August 1, 2024 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants