Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDEV-304 Update subsample details when search changes #77

Conversation

rlamacraft
Copy link
Contributor

When the subsample search within the sample form changes (e.g. the user searches for a particular subsample using the query string field), the subsample details panel should update so that we're not showing the details of subsample that are no longer in the table.

This is somewhat complicated by the next and previous buttons below the details panel as they manipulated the search when the currently shown subsample is up against a page boundary. The finer details of this complication are in the code comments.

@rlamacraft rlamacraft merged commit bd7f0b4 into rspace-os:main Aug 5, 2024
2 checks passed
@rlamacraft rlamacraft deleted the rsdev-304-updating-subsample-details branch August 5, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant