-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDEV-271: Integration with Digital Commons Data #84
RSDEV-271: Integration with Digital Commons Data #84
Conversation
fd76e3b
to
daa3f35
Compare
3cd1c26
to
f00737d
Compare
f00737d
to
fd47d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't actually test, but the code looks good. Added a few minor comments.
...a/com/researchspace/webapp/controller/repositories/DigitalCommonsDataUIConnectionConfig.java
Outdated
Show resolved
Hide resolved
...a/com/researchspace/webapp/controller/repositories/DigitalCommonsDataUIConnectionConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/com/researchspace/webapp/integrations/digitalcommonsdata/Base64Util.java
Outdated
Show resolved
Hide resolved
a50e41e
to
ec6e761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Left a couple of comments.
I'm not 100% about the database column changes. Looking at other changesets where there are column modifications they run in the run
context only. I think those modifications to column size should also be added to the hibernate entity in rspace-core-model
. Maybe you know more than me about it though? It's quite confusing.
src/main/java/com/researchspace/service/impl/IntegrationsHandlerImpl.java
Outdated
Show resolved
Hide resolved
...a/com/researchspace/webapp/integrations/digitalcommonsdata/DigitalCommonsDataController.java
Outdated
Show resolved
Hide resolved
...a/com/researchspace/webapp/controller/repositories/DigitalCommonsDataUIConnectionConfig.java
Outdated
Show resolved
Hide resolved
...a/com/researchspace/webapp/controller/repositories/DigitalCommonsDataUIConnectionConfig.java
Show resolved
Hide resolved
...a/com/researchspace/webapp/integrations/digitalcommonsdata/DigitalCommonsDataController.java
Outdated
Show resolved
Hide resolved
...m/researchspace/webapp/controller/repositories/DigitalCommonsDataUIConnectionConfigTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/researchspace/webapp/integrations/digitalcommonsdata/Base64TestUtil.java
Outdated
Show resolved
Hide resolved
Hey @rs-fraser |
ec6e761
to
63d2871
Compare
6cc9a12
to
3b52911
Compare
✅ Tested successfully on AWS ✅
origin/rsdev-272-digital-commons-ui
origin/RSDEV-221-ALTOGETHER
https://rsdev-221-altogether-4.researchspace.com
intohttps://dcd-test.researchspace.com
AWS Test Evidence:
RSDEV-271-test-evidence-AWS.mp4