Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDEV-271: Integration with Digital Commons Data #84

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

rs-nicof
Copy link
Contributor

@rs-nicof rs-nicof commented Aug 13, 2024

✅ Tested successfully on AWS ✅

  • added UI changes from @rlamacraft 's remote branch: origin/rsdev-272-digital-commons-ui
  • merged all into the remote branch: origin/RSDEV-221-ALTOGETHER
  • mapped the address https://rsdev-221-altogether-4.researchspace.com into https://dcd-test.researchspace.com

AWS Test Evidence:

RSDEV-271-test-evidence-AWS.mp4

@rs-nicof rs-nicof force-pushed the RSDEV-271-web-2 branch 8 times, most recently from fd76e3b to daa3f35 Compare August 14, 2024 12:01
@rs-nicof rs-nicof force-pushed the RSDEV-271-web-2 branch 8 times, most recently from 3cd1c26 to f00737d Compare August 16, 2024 09:50
@rs-nicof rs-nicof requested a review from mKowalski256 August 16, 2024 09:52
@rs-nicof rs-nicof marked this pull request as ready for review August 16, 2024 09:52
Copy link
Contributor

@mKowalski256 mKowalski256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually test, but the code looks good. Added a few minor comments.

@rs-nicof rs-nicof force-pushed the RSDEV-271-web-2 branch 6 times, most recently from a50e41e to ec6e761 Compare August 20, 2024 17:21
Copy link
Contributor

@rs-fraser rs-fraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Left a couple of comments.

I'm not 100% about the database column changes. Looking at other changesets where there are column modifications they run in the run context only. I think those modifications to column size should also be added to the hibernate entity in rspace-core-model. Maybe you know more than me about it though? It's quite confusing.

@rs-nicof
Copy link
Contributor Author

Code looks good. Left a couple of comments.

I'm not 100% about the database column changes. Looking at other changesets where there are column modifications they run in the run context only. I think those modifications to column size should also be added to the hibernate entity in rspace-core-model. Maybe you know more than me about it though? It's quite confusing.

Hey @rs-fraser
yes I had too do the changes becasue the token we are saving is actually longer than anyone else ever saved.
It was generating an error while inserting: Data is too long
That's why we had to increase the column size for those fields, and that needs to be done in PROD as well

@mKowalski256 mKowalski256 merged commit e2dd922 into rspace-os:main Aug 26, 2024
2 checks passed
@mKowalski256 mKowalski256 deleted the RSDEV-271-web-2 branch August 26, 2024 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants