RSDEV-224 Cosmetic tweaks to audit page #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, but I've noticed one incorrect id element after refactoring - makes 'users' filter not appearing for the PI.
Also, as the content of 'Time' column is now shorter, I believe the width of that column could be reduced from 25% to 20% here.
| by <a href="#" id="oids" class="addRow"><spring:message code="audit.identifiers.label"/></a>, | ||
| by <a href="#" id="dates" class="addRow"><spring:message code="audit.date.label"/></a> | ||
| and | ||
| by <a href="#" id="dates" class="addRow"><spring:message code="audit.users.label"/></a> |
There was a problem hiding this comment.
should be id="users" in this line
There was a problem hiding this comment.
oops, yep, fixed
Only down to 22% as otherwise it wraps where there's a long timezone offset |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes: