Skip to content

Commit 197a44f

Browse files
committed
🔊 Warn about deprecated responses usage
This was extracted from #93 and split into a separate PR. This allows us to prepare dependent projects for the new behavior before their logs are flooded with deprecation warnings.
1 parent ed4786b commit 197a44f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/net/imap.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2091,7 +2091,7 @@ def responses(type = nil)
20912091
elsif type
20922092
raise ArgumentError, "Pass a block or use #clear_responses"
20932093
else
2094-
# warn("DEPRECATED: pass a block or use #clear_responses", uplevel: 1)
2094+
warn("DEPRECATED: pass a block or use #clear_responses", uplevel: 1)
20952095
@responses
20962096
end
20972097
end

test/net/imap/test_imap.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -974,10 +974,10 @@ def test_responses
974974
assert_equal(1, imap.responses("RECENT", &:last))
975975
assert_raise(ArgumentError) do imap.responses("UIDNEXT") end
976976
# Deprecated style, without a block:
977-
# assert_warn(/Pass a block.*or.*clear_responses/i) do
978-
# assert_equal(%i[Answered Flagged Deleted Seen Draft],
979-
# imap.responses["FLAGS"]&.last)
980-
# end
977+
assert_warn(/Pass a block.*or.*clear_responses/i) do
978+
assert_equal(%i[Answered Flagged Deleted Seen Draft],
979+
imap.responses["FLAGS"]&.last)
980+
end
981981
imap.logout
982982
ensure
983983
imap.disconnect if imap

0 commit comments

Comments
 (0)