Skip to content

Consider extra empty space in BODYSTRUCTURE #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Consider extra empty space in BODYSTRUCTURE #271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6dfd50
Consider extra empty space in BODYSTRUCTURE
gaynetdinov Apr 19, 2024
a103fee
Update lib/net/imap/response_parser.rb
gaynetdinov Apr 23, 2024
3ed0837
Add a comment section to the extra space test
gaynetdinov Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/net/imap/response_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,6 +1157,7 @@ def body_fields
def body_fld_param
return if NIL?
param = {}
shift_token if @token.symbol == T_SPACE
lpar
name = case_insensitive__string; SP!; param[name] = string
while SP?
Expand Down
71 changes: 71 additions & 0 deletions test/net/imap/fixtures/response_parser/body_structure_responses.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,77 @@
4383638 NIL (\"attachment\" (\"filename\" \"test.xml\")) NIL NIL) \"mixed\"
(\"boundary\" \"001a1137a5047848e405157ddaa3\") NIL))\r\n"

test_bodystructure_extra_space:
:response: "* 1 FETCH (UID 1 BODYSTRUCTURE (((\"text\" \"plain\" (\"charset\" \"UTF-8\") NIL
NIL \"7bit\" 409 7 NIL NIL NIL)(\"text\" \"html\" (\"charset\" \"UTF-8\") NIL NIL \"7bit\"
592 10 NIL NIL NIL) \"alternative\" (\"boundary\" \"--==_mimepart_5277b641dcc3_57d5887e8325d8\"
\"charset\" \"UTF-8\") NIL NIL) \"mixed\" (\"boundary\" \"--==_mimepart_5277b64110f79_57d5887e832634\"
\"charset\" \"UTF-8\") NIL NIL))\r\n"

:expected: !ruby/struct:Net::IMAP::UntaggedResponse
name: FETCH
data: !ruby/struct:Net::IMAP::FetchData
seqno: 1
attr:
UID: 1
BODYSTRUCTURE: !ruby/struct:Net::IMAP::BodyTypeMultipart
media_type: MULTIPART
subtype: MIXED
parts:
- !ruby/struct:Net::IMAP::BodyTypeMultipart
media_type: MULTIPART
subtype: ALTERNATIVE
parts:
- !ruby/struct:Net::IMAP::BodyTypeText
media_type: TEXT
subtype: PLAIN
param:
CHARSET: UTF-8
content_id:
description:
encoding: 7BIT
size: 409
lines: 7
md5:
disposition:
language:
location:
extension:
- !ruby/struct:Net::IMAP::BodyTypeText
media_type: TEXT
subtype: HTML
param:
CHARSET: UTF-8
content_id:
description:
encoding: 7BIT
size: 592
lines: 10
md5:
disposition:
language:
location:
extension:
param:
BOUNDARY: --==_mimepart_5277b641dcc3_57d5887e8325d8
CHARSET: UTF-8
disposition:
language:
location:
extension:
param:
BOUNDARY: --==_mimepart_5277b64110f79_57d5887e832634
CHARSET: UTF-8
disposition:
language:
location:
extension:
raw_data: "* 1 FETCH (UID 1 BODYSTRUCTURE (((\"text\" \"plain\" (\"charset\" \"UTF-8\") NIL NIL
\"7bit\" 409 7 NIL NIL NIL)(\"text\" \"html\" (\"charset\" \"UTF-8\") NIL NIL \"7bit\"
592 10 NIL NIL NIL) \"alternative\" (\"boundary\" \"--==_mimepart_5277b641dcc3_57d5887e8325d8\"
\"charset\" \"UTF-8\") NIL NIL) \"mixed\" (\"boundary\" \"--==_mimepart_5277b64110f79_57d5887e832634\"
\"charset\" \"UTF-8\") NIL NIL))\r\n"

test_bodystructure_mixed_boundary:
:response: "* 2688 FETCH (UID 179161 BODYSTRUCTURE ((\"TEXT\" \"PLAIN\" (\"CHARSET\"
\"iso-8859-1\") NIL NIL \"QUOTED-PRINTABLE\" 200 4 NIL NIL NIL)(\"MESSAGE\"
Expand Down