Use non_arc_srcs instead of srcs for objc_library, since protoc-generated .m files don't use ARC.
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enerated .m files don't use ARC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to build & run
tools/rulegento make the changes to modules/objc/objc_(grpc)_library.bzl files, though I have validated that the if the files are edited directly, this change works for me as expected. I'm happy to run, rebuild, and test if someone can help me out with that.For the actual ARC change, see the Objective-C protobuf Building documentation note about ARC: "If the target is using ARC, remember to turn off ARC (-fno-objc-arc) for the .m files.