fix ChatSummaryMemoryBuffer._summarize_oldest_chat_history #17845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
| role=MessageRole.SYSTEM, | ||
| content=self.summarize_prompt, |
There was a problem hiding this comment.
Hmm, so self.summarize_prompt is already included when you run self._get_prompt_to_summarize(..) (check the end of that function)
Maybe the only change we needed here changing the summarize prompt to the user role?
There was a problem hiding this comment.
Thanks for the response @logan-markewich
what do you think about my last commit to this branch where I remove the prompt += self.summarize_prompt or "" from _get_prompt_to_summarize ? this way we send the instruction as system role and the context as user role which IMO is better than sending both as user role. also IMO it's better to put the instruction before the context rather than after. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChatSummaryMemoryBuffer._summarize_oldest_chat_history is crashing due to sending a single message with role system while Anthropic expects also a user message. Also current implementation is missing the instruction to summarize (summarize_prompt) which I added as role: system and moved context to next message as role: user