add modepath util and cache #18
Open
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pandyamarut <pandyamarut@gmail.com>
|
it looks OK (but we really should have support for multiple models here - the limit on the front-end is only temporary) Can you demonstrate this by building the docker container manually and deploying using the UX? Re: our slack conversation |
ef0xa
suggested changes
Feb 10, 2025
There was a problem hiding this comment.
How can this possibly work? You're assigning a variable to an instance of a class with no parent. That variable is never used. It can't be passed to the requests, because you don't do that. It can't be passed to the server, because you'd have to set the environment variable "model_name".
Are you missing a step? Or is there some python metaprogramming magic going on here I don't understand?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.