Full Bip322 signatures #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just merged #6, so that we both have consistent formatting across our editors. Could you resolve the conflicts and fix the formatting? Then I can have a look at this properly :) |
|
@raphjaph upd8d |
raphjaph
approved these changes
Aug 2, 2024
src/lib.rs
Outdated
Comment on lines
11
to
14
| pub use sign::{full_sign, simple_sign}; | ||
|
|
||
| mod verifier; | ||
| pub use verifier::{full_verify, simple_verify}; |
There was a problem hiding this comment.
I prefer having the pub use combined and the modules underneath each other.
Suggested change
| pub use sign::{full_sign, simple_sign}; | |
| mod verifier; | |
| pub use verifier::{full_verify, simple_verify}; | |
| mod verifier; | |
| pub use { | |
| sign::{full_sign, simple_sign}, | |
| verifier::{full_verify, simple_verify}, | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.