Depend on bitcoin v0.32.0-rc
#157
Conversation
tcharding
force-pushed
the
test-bitcoin
branch
2 times, most recently
from
719706d to
34c19db
Compare
Cargo.toml
Outdated
| @@ -11,7 +11,7 @@ edition = "2018" | |||
| categories = ["cryptography::cryptocurrencies", "development-tools::testing"] | |||
|
|
|||
| [dependencies] | |||
| bitcoincore-rpc = { version = "0.18.0" } | |||
| bitcoincore-rpc = { version = "0.19.0" } | |||
There was a problem hiding this comment.
Since there are no source code changes I wonder if we can use a ranged version here.
There was a problem hiding this comment.
Interesting thought, I'll give it a shot.
There was a problem hiding this comment.
Works here, didn't find anywhere else in the stack that we could use it though.
There was a problem hiding this comment.
This crate I think is particularly important because we use it in our test infrastructure, and we have wound up having delays in the past because of it even though it's not a direct dependency. Which is pretty frustrating.
Similar story with rust-bitcoincore-rpc which this depends on, but I think having a ranged dep would be harder there. (As you say, it's not trivial at least.)
I wonder if we could even lower the bottom value of the range..
There was a problem hiding this comment.
It works back to 0.17.0 (see #158).
Test the latest bitcoin release candidate. Includes bumping the version numbers so we can use this branch to test crates further up the stack.
|
Testing is done, new release is out. |
Test the latest bitcoin release candidate. Includes bumping the version numbers so we can use this branch to test crates further up the stack.