Clean up tests #56
Merged
Clean up tests #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2025
apoelstra
reviewed
Feb 10, 2025
integration_test/tests/wallet.rs
Outdated
| #[cfg(feature = "TODO")] | ||
| // TODO: We are getting an error for missing `pubkeys` field but the field is optional? |
There was a problem hiding this comment.
In 86dc357:
You need #[serde(default)] to make an Option<T> field actually optional. Otherwise it is required to be present and allowed to be null.
There was a problem hiding this comment.
Legend. So that means all the other Option fields must be getting null because this is the first time I had this problem and its definitely not the first usage of Option. TIL. Thanks.
apoelstra
reviewed
Feb 10, 2025
integration_test/tests/wallet.rs
Outdated
| // node.mine_a_block(); | ||
|
|
||
| // let json = node.client.get_address_info(&address).expect("getaddressinfo"); | ||
| // assert!(json.into_model().is_ok()); |
There was a problem hiding this comment.
In 86dc357:
Did you intend to add so much commented-out code in a PR titled "clean up tests"? Did you mean to call it "make tests less clean"? ;)
There was a problem hiding this comment.
lol, fair points. Although I do like that title - make tests less clean.
We have a function that funds the wallet - use it.
Add an additional call to `get_balance` after funding the wallet.
tcharding
force-pushed
the
02-10-testing
branch
from
16cd292 to
13c8e9f
Compare
|
utACK 13c8e9f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do some trivial integration test clean ups.