Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grep for TODO #1

Open
tcharding opened this issue Apr 4, 2024 · 1 comment
Open

Grep for TODO #1

tcharding opened this issue Apr 4, 2024 · 1 comment

Comments

@tcharding
Copy link
Member

Consider adding a tool that greps for TODO (excluding changelog) as part of pre-release checks, at least for rust-bitcoin we should have no todo's in the codebase. I personally use them for questions and todos during dev that should not be merged but they slip through into master occasionally and should definitely not be released.

Note in point:

cd path/to/rust-bitcoin
git checkout 85157078
git grep TODO
bitcoin/CHANGELOG.md:1:  # 0.32.0 - TODO: Add date when we do final release
bitcoin/src/consensus/mod.rs:151:            Other(_) => None, // TODO: Is this correct?
@apoelstra
Copy link
Member

Also FIXME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants