Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Shellcheck stuff needs documenting #9

Open
tcharding opened this issue May 22, 2024 · 1 comment
Open

ci: Shellcheck stuff needs documenting #9

tcharding opened this issue May 22, 2024 · 1 comment

Comments

@tcharding
Copy link
Member

We just started adding a shellcheck CI job all over the place, it requires specific code comments to remove false positives. We should add these to the ci/README.md.

@apoelstra
Copy link
Member

It would be nicer if we could somehow change the way we source stuff so we wouldn't need the warnings.

As always, it would be nice to switch away from shell, but IIRC we have never found a suitable replacement language that everybody can tolerate (and the chatbot has made shell much more tolerable..).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants