Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention to README re status of the crate #101

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

tcharding
Copy link
Member

This crate is in maintenance mode sine libbitcoinconsensus has been deprecated and removed from Core.

Add a section to the docs so folk are aware of it.

Close: #100

@tcharding
Copy link
Member Author

This is docs changes to the README file only - all CI fails are unrelated. I've not got the motivation to even look at them right now.

README.md Outdated

> In the future, libbitcoinkernel will provide a much more useful API that is aware of the UTXO set, and therefore be able to fully validate transactions and blocks.

And was [remove in Bitcoin Core v28](https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-28.0.md#libbitcoinconsensus-removal).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 7a8bf9b:

remove should be removed.

Otherwise LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

This crate is in maintenance mode sine `libbitcoinconsensus` has been
deprecated and removed from Core.

Add a section to the docs so folk are aware of it.

Close: rust-bitcoin#100
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3e0eefc

@apoelstra apoelstra merged commit c4642cc into rust-bitcoin:master Feb 14, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notice about libbitcoinconsensus deprecation
2 participants