Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking PR v0.21.2-0.6.0 #70

Closed
wants to merge 6 commits into from

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Dec 1, 2023

Vendor Bitcoin Core v0.21.2 by way of a new script, similar to the one in rust-secp256k1.

Commit: 755e90f5b7 Fix Bitcoin Core 0.21.2 upgrade has two co-developers, it is work from ages ago.

Resolves: #31

@tcharding tcharding changed the title Release tracking PR V0.21.2 0.6.0 Release tracking PR v0.21.2 0.6.0 Dec 1, 2023
@tcharding tcharding changed the title Release tracking PR v0.21.2 0.6.0 Release tracking PR v0.21.2-0.6.0 Dec 1, 2023
Instead of using a subtree add a script to vendor Bitcoin Core. Based on
the one in `rust-secp256k1`.
Run the vendoring script:

   `./vendor-bitcoin-core.sh v0.21.2`
Fix the build after vendoring new version of Core.

Includes changes to the build script by Jake and update to the C++
toolchain suggested by Richard.

Co-developed-by: Jake Rawsthorne <jake@jakerawsthorne.co.uk>
Co-developed-by: Richard Ulrich <richard.ulrich@seba.swiss>
Add a changlog entry and bump the version. There are no patches other
than vendoring new Core vension since the 0.20.2-0.6.0 release.
@tcharding tcharding marked this pull request as ready for review December 11, 2023 05:04
@tcharding
Copy link
Member Author

I've tested the script using

CORE_VENDOR_CP_NOT_CLONE=yes \
CORE_VENDOR_REPO=/home/tobin/build/github.com/tcharding/bitcoin \
contrib/vendor-bitcoin-core.sh v0.21.2 0.6.0 -f

As well as by cloning contrib/vendor-bitcoin-core.sh v0.21.2 0.6.0

@tcharding tcharding marked this pull request as draft December 11, 2023 06:27
@tcharding
Copy link
Member Author

Needs #72 to resolve.

@tcharding
Copy link
Member Author

Superseded by #77

@tcharding tcharding closed this Dec 15, 2023
@tcharding tcharding deleted the v0.21.2-0.6.0 branch January 14, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan to upgrade to 0.21 ?
1 participant