Add ffi module #71
Merged
Add ffi module #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the docs on `verify` by doing: - Attempt to make the docs more terse with no loss of meaning. - Remove link to transactions, no need to bless a specific explorer, folk can use the explorer of their choice to look things up.
Move the error code to the bottom of the file because it is boring and should not be looked at. Code move only, no other changes.
Wildcards obfuscate imports; import the types explicitly. Refactor only, no logic changes.
The C function declarations can go at the bottom, based on the principle of putting the most important stuff at the top. Refactor only, no logic changes.
We don't need to see C++ build warnings for implicit fallthrough.
We have moved away from using this comment in the rest of the `rust-bitcoin` org repos, do so here also.
We use github actions for CI now, we no longer need the old travis config file.
In order to de-clutter the HTML docs add a public submodule `ffi` and put the C function definitions in it.
apoelstra
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #67 without the final version bump patch.
Do a bunch of cleanups then add an
ffimodule to encapsulate the FFI function declarations.