-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tracking PR: v0.101.0+0.21.2
#77
Conversation
v0.101.0+0.21.2
Vendor Bitcoin Core v0.21.2
v0.101.0+0.21.2
Vendor Bitcoin Core v0.21.2v0.101.0+0.21.2
There was a typo in yesterdays tag, I've fixed it up, delete the wrong one and pushed the new one, you will see the wrong one locally still @apoelstra. Please review this PR at the same time as #78. |
phew! I woke up in the night and remembered I hadn't built |
The tag you pushed appeared to be unsigned so I replaced it with a signed one :). It should be correct now. |
As before, can you separate the "bump version and release" commit into its own PR? |
Oh yep, can do. Can you tell me what your scripts don't like about it when its together in a single PR, perhaps then I will internalise it and remember for future. |
@tcharding it causes my lockfiles to change partway through the PR. But the lockfiles are provided externally and I can't specify different ones for different commits (my scripts automatically compute the set of commits per PR, I don't know them and can't attach metadata to them). An alternate solution would be to pull the lockfiles into the crate, like we do with rust-bitcoin and rust-secp. |
So for those you just run CI with recent and minimal lockfiles? I can do that same set up here if it helps. |
Yeah. That'd be great. |
12d7ec3 Fix Bitcoin Core 0.21.2 upgrade (Tobin C. Harding) a4f30ef Vendor Bitcoin Core v0.21.2 (Tobin C. Harding) 8b3d23f Update README about vendoring (Tobin C. Harding) 3ca86b9 Remove the depend directory (Tobin C. Harding) 619611e Add Bitcoin Core vendor script (Tobin C. Harding) Pull request description: This is #77 without the version bump patch. Upgrade to a new way of vendoring Core and vendor version 0.21.2 - note please this will be directly followed by an upgrade to 0.21-final. Done separately to proof out the workflow of such an upgrade. ACKs for top commit: apoelstra: ACK 12d7ec3 Tree-SHA512: f708b4bda1a209afe7552ec0e691ed104847d4a4a5fae6cd13f2da8f3a205c0a652ced8883900b9ce312cb8f4f39f77f0abbdf3372016c5af7aeddc3e33984ba
07bd9e2
to
4978dc6
Compare
Next step is #81 and then this one - BOOM. |
4978dc6
to
37f2acc
Compare
Please ack, merge, tag, publish, and party. |
Add a changlog entry and bump the version. There are no patches other than vendoring new Core vension since the 0.100.0+0.20.2 release.
37f2acc
to
119126f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 119126f
Tagged and published. |
ae41548 Vendor Bitcoin Core v0.21-final (Tobin C. Harding) Pull request description: Vendor the final release of the 0.21 series of Bitcoin Core. Should be trivial to review, this PR is intentionally done separate to #77 so we can release both versions as a test run of how we will later do LTS releases as Core releases updated versions. Also, before we switched the version format we could not use the `-final` because it violated semver rules, now `0.101.1+0.21-final` builds just fine. ACKs for top commit: apoelstra: ACK ae41548 Tree-SHA512: f0edb7acf41c0796808f31c1e657dd310167966b4d68d684683141ecdd9afa8c0c495e7f51a946cf9f49cbdea1c2f6d6bead679a00b8486447d812ee5e8cda40
Add changelog and bump the version.