Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracknig PR: v0.103.0+23.2 #86

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jan 31, 2024

Add a changelog entry, bump the version, and update the lock files.

Add a changelog entry, bump the version, and update the lock files.
@tcharding tcharding marked this pull request as ready for review February 2, 2024 23:24
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b73899f

@apoelstra apoelstra merged commit c4610cc into rust-bitcoin:master Feb 3, 2024
5 checks passed
@apoelstra
Copy link
Member

cargo publish is failing with

  cargo:warning=depend/bitcoin/src/primitives/transaction.h:10:10: fatal error: consensus/amount.h: No such file or directory

  cargo:warning=   10 | #include <consensus/amount.h>

  cargo:warning=      |          ^~~~~~~~~~~~~~~~~~~~

This doesn't happen with cargo test or cargo build or any other cargo invocation I can think of.

@apoelstra
Copy link
Member

I think we need to remove /bitcoin/src/consensus/** from the Cargo.toml exclude list.

Tamas added this in 876dc72. It looks like a clumsy way of excluding all the source code that exists in Core but isn't used by libbitcoinconsensus. Arguably we should revert that whole commit, but maybe we should just remove the specific directories that we need to remove. Which in this case is src/consensus.

@tcharding
Copy link
Member Author

Fixed as suggested in #88.

@tcharding tcharding deleted the 01-31-release-23.2 branch February 5, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants