Vendor Bitcoin Core v24.2 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
02-03-vendor-24.2
branch
2 times, most recently
from
75b74ed to
ca3af0a
Compare
|
Not sure what to make of the build failures, EDIT: Silly me, its |
tcharding
force-pushed
the
02-03-vendor-24.2
branch
3 times, most recently
from
4bbb167 to
a61cb1e
Compare
Merged
|
Oh yeah, fixed it! |
Run the vendoring script:
`./contrib/vendor-bitcoin-core.sh v24.2`
To get the new code to build we need to patch the `build.rs` file:
- Add `.include("depend/bitcoin/src/secp256k1/include")`
- Remove unnecessary include (`src/secp256k1`, no source/header files)
- Group `define` statements.
- Add two additional source files to build.
There are a couple of flags that are no longer used. I did not check this but rather just copied rust-bitcoin/rust-secp256k1#536
tcharding
force-pushed
the
02-03-vendor-24.2
branch
from
a61cb1e to
6730e46
Compare
apoelstra
approved these changes
Feb 4, 2024
|
I've got the release branch on my machine at home, I'll be back there in an hour to rebase it and push it up. |
|
Let me know please if you didn't want that merged for some reason. |
|
#90 is ready to go. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the vendoring script:
./contrib/vendor-bitcoin-core.sh v24.2Also, patch the
build.rsfile to add: