Remove SECP256K1_BUILD #89
Conversation
Setting this variable causes a build warning, removing it doesn't seem to break anything and removes the warning. Also we do not set this variable when building `secp256k1-sys` over in the secp crate. I have no idea what the variable was intended to do though.
|
Like with SECP256K1_API, this is used to guard the include file to make sure you're not trying to build some sketchy half-build version of libsecp while exposing its normal API. We could drop it here without harm since we don't use the include files, though I'm a little sketched out because this informally is the "production build" flag for upstream. What warning does it cause? |
warning: depend/bitcoin/src/secp256k1/src/secp256k1.c:7: warning: "SECP256K1_BUILD" redefined
warning: 7 | #define SECP256K1_BUILD
warning: |
warning: <command-line>: note: this is the location of the previous definition |
Which include files did you mean? I had to add a couple of |
|
Oh, lol, we should definitely not be defining this manually since it's defined in secp256k1.c. This originates in #13 and it looks like nobody commented on it. The include file I mean is secp256k1.h. |
|
A bunch of the defines here look outdated. See rust-bitcoin/rust-secp256k1#536 |
Setting this variable causes a build warning, removing it doesn't seem to break anything and removes the warning. Also we do not set this variable when building
secp256k1-sysover in the secp crate.I have no idea what the variable was intended to do though.