CI: Run fuzzer daily #683
CI: Run fuzzer daily #683
Conversation
Update the `fuzz/generate-files.sh` script to mimic that in `rust-bitcoin` and generate a new fuzz job that runs the fuzz tests daily for an hour. Run the fuzz job the time that `rust-bitcoin` fuzz job finishes - I don't know if that matters. I still don't know if there are org wide limits or just repo limits but it doesn't hurt to run at a different time.
| # - 11pm PDT | ||
| # - 7am CET | ||
| # - 5pm AEDT | ||
| - cron: '00 06 * * *' |
There was a problem hiding this comment.
We need to change this to 05 or update the comment above.
I know that this is "copy-pasta" left over from the another PR that I saw earlier that had both 06 and 6am
There was a problem hiding this comment.
Yep. (At least, that's how I read it.)
There was a problem hiding this comment.
Oh woops, I changed the three bottom ones and missed the top one (not shown here). While investigating I noticed that I totally botched this PR, I didn't change the output file to cron-fuzz-daily.yml and I didn't run the script either - god damn, it is hard to get good help. Will follow up.
There was a problem hiding this comment.
Man, now I'm confused. A job cron-daily-fuzz ran last night.
There was a problem hiding this comment.
Oh, I must have created the yaml file manually and not run generate-files.sh - face palm.
There was a problem hiding this comment.
Thanks for finding by bugs @storopoli!
There was a problem hiding this comment.
I'm also confused -- I ran the script locally and the diff was clean (didn't even create any other files). Are you saying it did nothing?
There was a problem hiding this comment.
Seems its too early in the morning for my brain to context switch back into this properly but if you check cron-daily-fuzz.sh you will ask yourself "who wrote this rubbish and how did it get in master?" For example it still runs on pull_request - all fixed in #684. As for postmortem I'm not sure how I botched it so badly.
There was a problem hiding this comment.
I think I must have tested the fuzz script in a different repo or something. This is definitely broken as hell :).
I royally botched up PR rust-bitcoin#683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set).
I royally botched up PR rust-bitcoin#683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set).
bd1df30 Sort fuzz files when finding (Tobin C. Harding) 73d81e5 Follow up from cron-daily-fuzz PR (Tobin C. Harding) Pull request description: I royally botched up PR #683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set). ACKs for top commit: apoelstra: ACK bd1df30 Tree-SHA512: 2af4c030398a79d1de2b2b5d49a399806e21681e5783d97bc139deb6004fed6b34461fb3547070a767d6fff1f76421c775a0a7d1ddc1de05dc50a3d08682618d
I royally botched up PR rust-bitcoin#683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set).
Update the
fuzz/generate-files.shscript to mimic that inrust-bitcoinand generate a new fuzz job that runs the fuzz tests daily for an hour.Run the fuzz job the time that
rust-bitcoinfuzz job finishes - I don't know if that matters. I still don't know if there are org wide limits or just repo limits but it doesn't hurt to run at a different time.