Follow up from cron-daily-fuzz PR #684
Conversation
|
In 1f4b007: I get a different sort order than you for the fuzztests. I think we need to set the locale. |
|
Actually we currently don't sort these at all.. we just run |
|
Done as an additional patch and added rust-bitcoin/rust-bitcoin-maintainer-tools#5 |
|
Guess we need to pin the nightly compiler here too :( |
|
I was trying to get away from doing that in ever repo, I am not at all keen to be manually merging an "update msrv" patch on every repo we have twice a week, that is a job for a robot, or just kill me now. I mean, I can write a script that just does it but then we may as well have bot run the script. Its literally just, update msrv, if CI is green, merge it. |
|
@tcharding As a matter of policy, I don't want bots to merge things unfortunately. But I see your point. This is entirely mechanical and pretty annoying to do. Maybe if we made the update be every 2 weeks or something? |
|
I can handle once a week, I realised also that the first repo is the annoying one (requires installing the new toolchain, which is slow). The additional repos should be less painful. |
|
@tcharding in the "usual" case that CI passes, you don't need to install the toolchain. But yes, when things break, at least you only need to do it once.. |
|
Huh? As soon as it merges everyone needs to install the new toolchain to be able to build with nightly (at least if they use the |
|
Oh, interesting. I did not realize this. In my local CI I am always using the latest nightly (which does mean that the first job of the day is a bit slow) and on the CLI I have just been using whatever nightly I happen to have laying around, and only updating it when things change. |
|
Ah of course, I can just add |
I royally botched up PR rust-bitcoin#683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set).
Currently we don't sort the output of fuzz file names when finding them, this can lead to different output from `generate-files.sh` on different machines. Set the locale first because it effects sort order then sort the output of `find`.
tcharding
force-pushed
the
05-03-follow-up-cron-fuzz
branch
from
a86c0ee to
bd1df30
Compare
|
Ready to go! |
I royally botched up PR #683 which changed fuzzing to run daily, fix it up by doing:
generate-files.sh.generate-files.shto generate the yaml file.