remove win64_128bit_abi_hack #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That aarch64 failure can't be related to this PR, I think. The windows failure is suspicious but it's on win32 and this patch only affects 64bit systems so I don't think it can be that, either? |
|
The |
tgross35
force-pushed
the
win64_128bit_abi_hack
branch
from
ef328d9 to
349ad31
Compare
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Feb 20, 2025
Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758
|
r-l/rust update rust-lang/rust#137297 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2025
Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2025
Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Feb 23, 2025
Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758
tgross35
added a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
Since [1], the issue should be resolved so the workaround can be dropped. This reverts commit 88e83b9. [1]: rust-lang#759
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2025
Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Feb 23, 2025
Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2025
Rollup merge of rust-lang#137297 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 24, 2025
Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang/rust#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Feb 26, 2025
Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang/rust#116558 Link: rust-lang/compiler-builtins#758
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Feb 26, 2025
Update `compiler-builtins` to 0.1.147 Removes an ABI hack that used `<2 x i64>` to return `i128` in `xmm0` on Windows [1]. [1]: rust-lang/compiler-builtins#759 Link: rust-lang/rust#116558 Link: rust-lang/compiler-builtins#758 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For msvc and GNU targets, that hack is no longer needed -- rustc by itself now returns i128/u128 via xmm0 on these targets. That got implemented in rust-lang/rust#134290.
For the x86_64-unknown-uefi target, the situation still seems a bit unclear, but using a
repr(simd)is definitely wrong for that target as SIMD is not available. So I can't imagine that this PR would make anything any worse...Fixes #758