Why doesn't CompletionItem for std::thread include additionalTextEdits?

[jm-observer]

Hi, I'm developing a client that integrates with rust-analyzer, and I'm handling CompletionItem insertions.

When I complete something like thread, I get a CompletionItem that includes this field:

"data": {
  "imports": [{ "full_import_path": "std::thread" }]
}

However, the CompletionItem doesn't include any additionalTextEdits to insert use std::thread;.

My client does send completionItem.resolveSupport.properties = ["additionalTextEdits"], and I also call completionItem/resolve as needed.

Is this intentional behavior? Under what conditions does rust-analyzer decide to provide additionalTextEdits instead of data.imports? Should clients always handle data.imports themselves?

Thanks!

[flodiebold]

No, clients should never use anything in data, it's only for use by rust-analyzer for handling the resolve request. For an import completion there should always be additionalTextEdits (after resolve), as far as I can tell.

[Veykril]

Does the completion item change after the completionItem/resolve call?