completion.callable.snippets trigger parameterHints popup regardless of parameterHints.enabled flag

[jeremychone]

rust-analyzer version: 0.3.1221-standalone (73ab709 2022-09-24)
rustc version: rustc 1.64.0 (a55dd71d5 2022-09-19)
relevant settings: MacBook Pro M1, VSCode 1.71.2 (Universal)

Summary

In vscode when parameterHints is set to false (with "editor.parameterHints.enabled": false), the rust-analyzer.completion.callable.snippets will still trigger the paramerterHints popup on completion regardless of the parameterHints flag.

Steps to reproduce

In VSCode settings:

• "editor.parameterHints.enabled": false
• "rust-analyzer.completion.callable.snippets" = "fill_arguments" (or "add_parentheses")

Actual

When performing an auto complete, the parentheses or arguments will be completed correctly, but the parameterHint popup will be shown, even if editor.parameterHints.enabled was set to false.

The only way to avoid the parameterHints popup is to set the ...callable.snippets = "none" but then we lose the nice rust-analyzer parentheses or arguments auto completed.

Expected

Have the rust-analyzer.completion.callable.snippets follow the vscode parameterHints when deciding to show the parameterHints popup (but still autocomplete the parentheses or arguments as configured)

[Veykril]

We unconditionally make the client trigger the command

rust-analyzer/crates/rust-analyzer/src/to_proto.rs

Lines 1325 to 1332 in 97f8f4a

	pub(crate) fn trigger_parameter_hints() -> lsp_types::Command {
	lsp_types::Command {
	title: "triggerParameterHints".into(),
	command: "editor.action.triggerParameterHints".into(),
	arguments: None,
	}
	}
	}

We'll likely need to inspect the commands in completion items in our extension code and act accordingly.