std: move process implementations to sys
#136929
Open
+90
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
O-hermit
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
move_process_pal
branch
from
a3a3339 to
484706e
Compare
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
move_process_pal
branch
from
484706e to
5ce9e2c
Compare
|
☔ The latest upstream changes (presumably #137046) made this pull request unmergeable. Please resolve the merge conflicts. |
As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.
joboet
force-pushed
the
move_process_pal
branch
from
5ce9e2c to
fb1751f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #117276, this moves the implementations of
Processand friends out of thepalmodule and into thesysmodule, removing quite a lot of error-prone#[path]imports in the process (hah, get it ;-)). I've also made thezirconmodule a dedicated submodule ofpal::unix, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications insys). Also, theensure_no_nulsfunction on Windows now lives insys::pal::windows– it's not specific to processes and shared by the argument implementation.