Skip to content

Do not include NUL-terminator in computed length #142708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not include NUL-terminator in computed length #142708

wants to merge 1 commit into from

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jun 19, 2025 •
edited
Loading

This PR contains just the first commit of #142579 which changes it so that the string length stored in the Location is the length of the &str rather than the length of the &CStr. Since most users will want the &str length, it seems better to optimize for that use-case.

There should be no visible changes in the behavior or API.

@Darksonn Darksonn added the A-panic Area: Panicking machinery label Jun 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@Darksonn Darksonn mentioned this pull request Jun 19, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-panic Area: Panicking machinery S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darksonn @rustbot @Mark-Simulacrum