Skip to content

All HIR attributes are outer #142776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jun 20, 2025

Fixes #142649. Closes #142759.

All HIR attributes, including parsed and not yet parsed, will now be rendered as outer attributes by rustc_hir_pretty. The original style of the corresponding AST attribute(s) is not relevant for pretty printing, only for diagnostics.

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor

almost hehe, but this looks like a nice change!

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: hir: explicit panic
4 participants