-
Notifications
You must be signed in to change notification settings - Fork 13.5k
libtest: expose --fail-fast as an unstable command-line option #142807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
I can not yet find any in-tree tests for the libtest command line options... |
I locally tested this with However that does find a problem that doctests don't accept this option. |
cc @rust-lang/testing-devex |
Over at rust-lang/testing-devex-team#5, we're building up a list of all of the problems with the current doctest architecture. I've noted this for the next testing-devex meeting. |
As this builds on the original implementation and it was recognized as a hack by both the reviewer and the implementer, it would be good to get their feedback. My main concern is I've found PRs a poor place for collecting requirements / design information because they can come and go as different people work on it or even with the same author. Unsure if we should go ahead and do that discussion here or open an issue. |
(It's probably best as its own issue, PR discussions are very easy to become lost) |
This exposes the
fail_fast
option added in #105153 on the test harness command line, so that workflows that only want to know if any test fails can find out without waiting for everything to run. For example, cargo-mutants just needs to know if any tests fails. It only works with-Zunstable-options
.(Probably I should make an issue to stabilize it but I just wanted to see if the core change is OK, first.)